Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sidecar: Added support for streaming, chunked remote read. #1268

Merged
merged 1 commit into from
Aug 27, 2019
Merged

sidecar: Added support for streaming, chunked remote read. #1268

merged 1 commit into from
Aug 27, 2019

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Jun 21, 2019 •
edited
Loading

Fixes: #488

Signed-off-by: Bartek Plotka bwplotka@gmail.com

@bwplotka bwplotka self-assigned this Jun 21, 2019
@bwplotka bwplotka force-pushed the v0.5.0-rr branch 2 times, most recently from f5ddb66 to 9fb1f3f Compare June 21, 2019 14:07
This was referenced Jun 21, 2019
Closed
Closed
Closed
Closed
@bwplotka bwplotka force-pushed the v0.5.0-rr branch 3 times, most recently from 7bd205f to cedf673 Compare July 5, 2019 12:06
@bwplotka bwplotka mentioned this pull request Aug 14, 2019
Merged
@bwplotka bwplotka marked this pull request as ready for review August 15, 2019 17:39
@bwplotka bwplotka requested a review from brancz August 15, 2019 17:40
@bwplotka bwplotka force-pushed the v0.5.0-rr branch 12 times, most recently from 04bfeda to acf922d Compare August 18, 2019 12:57
@bwplotka bwplotka force-pushed the v0.5.0-rr branch 2 times, most recently from 6243e4d to 4f31ca5 Compare August 19, 2019 17:09
@bwplotka bwplotka mentioned this pull request Aug 19, 2019
Open
brancz
brancz approved these changes Aug 20, 2019
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@bwplotka bwplotka force-pushed the v0.5.0-rr branch 5 times, most recently from ef5d17b to a460fa6 Compare August 20, 2019 12:23
@bwplotka bwplotka force-pushed the v0.5.0-rr branch 4 times, most recently from 431aaf5 to e57811c Compare August 22, 2019 10:31
krasi-georgiev
krasi-georgiev reviewed Aug 22, 2019
View reviewed changes
Copy link
Contributor

@krasi-georgiev krasi-georgiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point me to the test that ensure a good behavior when the x-streamed-protobuf returns multi frames?

pkg/store/prometheus.go Outdated Show resolved Hide resolved
pkg/store/prometheus.go Outdated Show resolved Hide resolved
pkg/store/prometheus.go Outdated Show resolved Hide resolved
pkg/store/prometheus.go Show resolved Hide resolved
pkg/store/prometheus.go Outdated Show resolved Hide resolved
pkg/store/prometheus.go Show resolved Hide resolved
pkg/store/prometheus.go Show resolved Hide resolved
@bwplotka bwplotka force-pushed the v0.5.0-rr branch 2 times, most recently from c216e97 to d7b4aef Compare August 27, 2019 08:50
@bwplotka
Copy link
Member Author

bwplotka commented Aug 27, 2019 •
edited
Loading

@krasi-georgiev The merging multi series frame are tested in proxy code here: https://github.com/thanos-io/thanos/blob/master/pkg/store/proxy_test.go#L70

But adding more testcases.

@bwplotka bwplotka mentioned this pull request Aug 27, 2019
Closed
@bwplotka
Copy link
Member Author

Started discussion on the StoreAPI Series API invariant aka multi series frame here: #1464

@bwplotka
Copy link
Member Author

Changed this accordingly to #1464 decision. CC @krasi-georgiev

@bwplotka
sidecar: Added support for streaming, chunked remote read.
78ebeea 
Fixes: #488

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
@bwplotka bwplotka merged commit fbffc4b into master Aug 27, 2019
@bwplotka bwplotka deleted the v0.5.0-rr branch August 27, 2019 16:46
This was referenced Sep 13, 2019
Closed
Closed
@foobar foobar mentioned this pull request Jun 16, 2020
Open
@rishabhkumar92 rishabhkumar92 mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krasi-georgiev krasi-georgiev krasi-georgiev left review comments

@GiedriusS GiedriusS GiedriusS left review comments

@brancz brancz brancz approved these changes

@jojohappy jojohappy Awaiting requested review from jojohappy

@povilasv povilasv Awaiting requested review from povilasv

Assignees

@bwplotka bwplotka

Labels
component: sidecar feature request/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sidecar: Optimize Prometheus Remote Read API.
4 participants
@bwplotka @GiedriusS @brancz @krasi-georgiev